[v9] Backport Teleport Connect (2 of 5)#763
Conversation
| }, [disconnectAttempt.status]); | ||
|
|
||
| useEffect(() => { | ||
| if (cluster.connected) { |
There was a problem hiding this comment.
is optional chaining required here? just saw it on line 49
There was a problem hiding this comment.
Now that I look at it, it seems that the checks for cluster being null are unnecessary here. 🤔 If someone logs out from the cluster (and thus removes it) we remove any open resources from that cluster as well. We'll look into removing that after the preview release, thanks!
| css={` | ||
| white-space: nowrap; | ||
| `} |
There was a problem hiding this comment.
just curious between css and style, do both achieve the same thing (just syntax is a bit different?)
There was a problem hiding this comment.
@gzdunek Can you answer Lisa's question here? I remember you were changing that. ;)
There was a problem hiding this comment.
css works the same as styled(Text)... so you have access to the theme for example. Also, css generates a css class, while style adds inline style to the element.
There was a problem hiding this comment.
@gzdunek i see, thanks! should we be using css from now on? or does it matter?
There was a problem hiding this comment.
@kimlisa I think we can prefer css over style as it has more capabilities (and nicer syntax) :)
ravicious
changed the base branch from
ravicious/v9/backport-connect-1-of-5
to
teleport-v9
ravicious
changed the base branch from
teleport-v9
to
ravicious/v9/backport-connect-1-of-5
Versions lower than 23.0.2 don't work on newest macOS, see: * electron-userland/electron-builder#6732 * electron-userland/electron-builder#6606
This commit removes a bunch of unused protobufs and also updates some of those that got updated on the teleterm branch in the teleport repo. The biggest change from all of them is that LoginRequest now has oneof on Sso and Local. [1] This is because a login request should have either Sso or Local params, but not both at the same time. The previous implementation called both `setSso` and `setLogin` on the same object. This no longer works with the use of `oneof`, because calling `setLogin` after `setSso` would clear the `Sso` params. [2] [1] gravitational/teleport#10286 (comment) [2] https://developers.google.com/protocol-buffers/docs/proto3#oneof_features
ravicious
force-pushed
the
ravicious/v9/backport-connect-2-of-5
branch
from
ebb197b to
5ded89c
Compare
ravicious
changed the base branch from
ravicious/v9/backport-connect-1-of-5
to
teleport-v9
4 participants
Type-checks and the tests are green.
Backport for the following PRs:
localClusterUriinto account inQuickInput#679Navigatorcode #685babel-plugin-styled-componentsin production and tests #697